Skip to content

Feature/ldap email #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bess wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Feature/ldap email #789

bess wants to merge 19 commits into from

Conversation

@bess
Copy link
Contributor

@bess bess commented Dec 15, 2017 •
edited
Loading

Closes #28
Closes #69

@bess bess mentioned this pull request Dec 15, 2017
Closed
4 tasks
@coveralls
Copy link

coveralls commented Dec 15, 2017

Coverage Status

Coverage increased (+0.003%) to 90.269% when pulling 2c89a04 on feature/ldap-email into 0925964 on master.

@bess bess force-pushed the feature/ldap-email branch from 2c89a04 to 67da034 Compare December 18, 2017 15:00
@coveralls
Copy link

coveralls commented Dec 18, 2017

Coverage Status

Coverage increased (+0.003%) to 90.269% when pulling 67da034 on feature/ldap-email into 0925964 on master.

@coveralls
Copy link

coveralls commented Dec 18, 2017

Coverage Status

Coverage decreased (-1.1%) to 89.153% when pulling a31204b on feature/ldap-email into 0925964 on master.

@coveralls
Copy link

coveralls commented Dec 18, 2017

Coverage Status

Coverage decreased (-1.1%) to 89.125% when pulling 226f8f5 on feature/ldap-email into 0925964 on master.

@bess bess force-pushed the feature/ldap-email branch from 226f8f5 to a8bc754 Compare December 18, 2017 19:32
@coveralls
Copy link

coveralls commented Dec 18, 2017

Coverage Status

Coverage decreased (-0.02%) to 89.268% when pulling a8bc754 on feature/ldap-email into a050e7d on master.

@coveralls
Copy link

coveralls commented Dec 18, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 89.236% when pulling a52163b on feature/ldap-email into a050e7d on master.

@bess bess closed this Dec 19, 2017
@bess bess reopened this Dec 19, 2017
@coveralls
Copy link

coveralls commented Dec 19, 2017

Coverage Status

Coverage decreased (-0.04%) to 89.252% when pulling a52163b on feature/ldap-email into a050e7d on master.

mark-dce and others added 8 commits January 3, 2018 19:56
@mark-dce
Add LDAP authentication using e-mail as the login id
568289f 
This commit adds the devise_ldap_authenticatable gem to support
authentication via LDAP.  The application already has devise installed,
so you only need to run the devise_ldap_authenticatable genearator
as described in https://github.com/cschiewek/devise_ldap_authenticatable#setup

The committ also adds the ladle gem to provide a LDAP server which
can be used in the test and development environments.  It also updates
Travis to start the LDAP server before running the test suite.
@bess @mark-dce
Add username to the user model
26800c3 
Update User factory to match
Configure Devise to user :username instead
of :email for authentication
@bess @mark-dce
Update notifications to respect user_key
e9b3700 
Instead of looking up users by email, use Hydra.config.user_key_field
and find_by_user_key methods so that when we update the user key
things don't break.
@bess @mark-dce
Create system users by username instead of email
3404d12 
Note we will also need to remove the password from this
method if we stop storing user passwords.
@bess @mark-dce
Use user_key instead of email in contribute controller
47152ce
@bess @mark-dce
Set email before save
b86db5d
@bess @mark-dce
Log in with username
68baac4
@bess @mark-dce
Define Tufts specific LDAP display name field
e0abbf3
@mark-dce mark-dce force-pushed the feature/ldap-email branch from a52163b to e0abbf3 Compare January 4, 2018 05:52
@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 89.703% when pulling e0abbf3 on feature/ldap-email into 18a4772 on master.

mark-dce and others added 6 commits January 5, 2018 10:53
@mark-dce @bess
Add LDAP authentication using e-mail as the login id
a28272b 
This commit adds the devise_ldap_authenticatable gem to support
authentication via LDAP.  The application already has devise installed,
so you only need to run the devise_ldap_authenticatable genearator
as described in https://github.com/cschiewek/devise_ldap_authenticatable#setup

The committ also adds the ladle gem to provide a LDAP server which
can be used in the test and development environments.  It also updates
Travis to start the LDAP server before running the test suite.
@bess
Add username to the user model
9cf239c 
Update User factory to match
Configure Devise to user :username instead
of :email for authentication
@bess
Update notifications to respect user_key
e966cb2 
Instead of looking up users by email, use Hydra.config.user_key_field
and find_by_user_key methods so that when we update the user key
things don't break.
@bess
Create system users by username instead of email
8a540d2 
Note we will also need to remove the password from this
method if we stop storing user passwords.
@bess
Use user_key instead of email in contribute controller
158af63
@bess
Set email before save
ba9af0c
@coveralls
Copy link

coveralls commented Jan 6, 2018

Coverage Status

Coverage decreased (-0.2%) to 89.569% when pulling eee9ab0 on feature/ldap-email into 18a4772 on master.

@coveralls
Copy link

coveralls commented Jan 6, 2018

Coverage Status

Coverage decreased (-0.1%) to 89.641% when pulling eee9ab0 on feature/ldap-email into 18a4772 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backlog don't merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bess @coveralls @mark-dce @shanitajohn